Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page Objects Sometimes Want to be Headless #11

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

jwmach1
Copy link

@jwmach1 jwmach1 commented Nov 16, 2011

Let Page objects choose to return a headless-type Reply object for custom status codes and the other goodies of Reply.

James and others added 22 commits November 15, 2011 21:48
…stom status codes and the other goodies of Reply
…tifactory

* create VelocityEngineProvider to create just one engine for all template compilations
…ethod interceptors (DecorateWidget change)
…oCompile Set was not compiling the @decorated pages because the DefaultPageBook.PageTuple.equals method only looked at the class.  This change incorporates the isDecorated boolean http://groups.google.com/group/google-sitebricks/browse_thread/thread/4ca57a97a8a31246
…eTuple, (2) that EmbedWidget has only one EmbeddedRespondFactory and (3) the EmbeddedRespondFactory was keeping a final StringBuilderRespond object to pass as the delegate to the factoried EmbeddedRespond. So, if two requests come in for the same page, they end up sharing a StringBuilderRespond
…ork from the private modifications, when a page returns a Reply, it is just returned from dispatch
@dhanji
Copy link
Owner

dhanji commented Nov 26, 2012

Hi James, do yo u mind flattening these into one commit so I can review them in one go?

Thanks... sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants